Add: directory attributes value validations by milov-dmitriy · Pull Request #857 · MultiDirectoryLab/MultiDirectory

milov-dmitriy · 2025-12-04T11:40:42Z

Задача: 792

Нужно реализовать поддерживаемую и расширяемую валидацию значений атрибутов любой директории согласно бизнес логике AD, правило валидации рассчитывается исходя из пары: Имя сущности (к которой относится директория) + Имя атрибута

Сделано:

добавлен класс валидации значений атрибутов директорий для LDAP запросов: add, modify, modifyDn
написаны тесты на сам валидатор значений
расширены тесты для add запроса

…task_792

Copilot

Pull request overview

This PR implements comprehensive validation for directory attribute values in LDAP operations according to Active Directory business logic. The validation rules are determined by the combination of entity type name and attribute name.

Added AttributeValueValidator class with validation rules for directory attributes across add, modify, and modifyDn LDAP operations
Introduced EntityTypeNames enum to standardize entity type references throughout the codebase
Integrated validation into DAOs, gateways, and LDAP request handlers with proper error handling

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`app/enums.py`	Added `EntityTypeNames` enum defining standard entity type constants
`app/ldap_protocol/ldap_schema/attribute_value_validator.py`	New validator class implementing business logic rules for attribute values
`app/ldap_protocol/ldap_requests/add.py`	Integrated validation for LDAP add operations with error handling
`app/ldap_protocol/ldap_requests/modify.py`	Added validation to modify operations
`app/ldap_protocol/ldap_requests/modify_dn.py`	Added validation to modifyDn operations
`app/ldap_protocol/ldap_requests/contexts.py`	Extended request contexts to include validator dependency
`app/ldap_protocol/ldap_schema/entity_type_dao.py`	Injected validator and applied validation during entity type operations
`app/ldap_protocol/policies/password/dao.py`	Added validator dependency for password attribute validation
`app/ldap_protocol/auth/setup_gateway.py`	Integrated validator into setup operations
`app/ioc.py`	Registered `AttributeValueValidator` in dependency injection container
`tests/test_ldap/test_attribute_value_validator.py`	Comprehensive test suite for validator covering all validation rules
`tests/test_api/test_main/test_router/test_add.py`	Extended tests to verify validation behavior in add operations
Multiple test files	Updated to use `EntityTypeNames` enum instead of string literals
`app/constants.py`	Updated entity type data structures to use `EntityTypeNames` enum
`app/repo/pg/tables.py`	Added database indexes for performance optimization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

milov-dmitriy · 2025-12-04T13:54:22Z

p.s. в ТестКлассах надо сделать свойство для хранения entity_type_name

…task_792

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

app/constants.py:1

Removed type ignore comments that are no longer necessary with proper typing.

"""Data variables.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

milov-dmitriy · 2025-12-05T15:16:04Z

!!! NOTE: После того как будет аппрув, нужно будет поменять целевую ветку с main на dev, сейчас это делать нельзя - можно потерять ~~комментарии~~ коммиты

* Add: directory attributes value validations (#857) * Add: addRequest validate `new_name` (#862) * fix: update push branch from main to dev in build workflow (#866) * Http codes with map 774 (#836) * Added dishka container to migrations (#868) * Refactor: integrate NetworkPolicyGateway into LDAP session management (#863) * Add default admin name 1111 (#872) * Refactor syslog-ng configuration and enhance SyslogSender class (#871) * Refactor: git checks (#869) * Add: global LDAP server (#875) * Fix: global ldap server (#877) * Rework dependencies initialization in migrations (#880) * add: UDP port mapping for LDAP service in docker-compose.yml (#882) * Refactor ldap server (#867) * Add: clear user password history (#874) * Fix migration 275222846605 (#881) * Add KRBAPIConnectionError handling to error map in krb5_router.py (#885) * Add: directory is_system (#884) * add: handling KRBAPIConnectionError in KerberosService exceptions (#886) * Refactor: merge enterprise tests (#887) * add: enqueue param for loguru (#888) * Add: tmpfs and volume prune and kadmin_api depends on kdc (#891) * New CI (#890) * add: Contact entity type (#896) * refactor: rename services to System (#883) * Hotfix262 (#898) * Fix: user addRequest: recreate principal if exists already (#897) * Enhance AddRequest: suppress KRBAPIPrincipalNotFoundError during principal deletion (#902) * Refactor: cosmetic (#900) * Add: Global Catalog logger (#892) * Refactor: ModifyRequest (#893) * Fix: Correct path assignment in _update_descendants function (#904) * refactor: fix paths kadmin_api entrypoint (#903) * add: rename services (#905) * fix: replace services with system (#906) --------- Co-authored-by: Milov Dmitriy <milovdd@mail.ru> Co-authored-by: Ruslan <khannanov.rus@gmail.com> Co-authored-by: Misha-Shvets <76677350+Misha-Shvets@users.noreply.github.com> Co-authored-by: Михаил Михайлов <90135860+TheMihMih@users.noreply.github.com>

milov-dmitriy added 8 commits December 1, 2025 19:52

add: attribute value validator (draft) task_792

ad05de4

add: substage done (draft) task_792

6094b69

Merge remote-tracking branch 'origin/main' into add_attr_validations_…

2c63916

…task_792

refactor: smfixes (draft) task_792

dd5218b

refactor: ssmfix task_792

dda6385

Merge remote-tracking branch 'origin/main' into add_attr_validations_…

7d1a363

…task_792

add: attr value validators task_792

efa1c37

refactor: smfix task_792

14c65c9

milov-dmitriy requested a review from Copilot December 4, 2025 11:40

milov-dmitriy self-assigned this Dec 4, 2025

milov-dmitriy added python Pull requests that update Python code ldap labels Dec 4, 2025

Merge remote-tracking branch 'origin/main' into add_attr_validations_…

f91d632

…task_792

Copilot AI reviewed Dec 4, 2025

View reviewed changes

milov-dmitriy added 2 commits December 4, 2025 14:48

fix: delete unused properties task_792

505d86e

fix: copilot alerts task_792

1b0da24

milov-dmitriy requested a review from Copilot December 4, 2025 11:54

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Comment thread app/ldap_protocol/ldap_requests/modify_dn.py Outdated

Comment thread app/ldap_protocol/ldap_requests/modify.py Outdated

Comment thread app/ldap_protocol/ldap_requests/add.py Outdated

Comment thread app/constants.py Outdated

fix: copilot alerts task_792

e4fb64c

milov-dmitriy requested a review from Copilot December 4, 2025 12:09

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Comment thread app/ldap_protocol/ldap_requests/modify_dn.py Outdated

Comment thread app/ldap_protocol/ldap_requests/modify.py Outdated

Comment thread app/ldap_protocol/utils/queries.py Outdated

Comment thread tests/test_api/test_main/test_router/test_add.py

fix: raises and naming task_792

686c6fb

milov-dmitriy requested a review from Copilot December 4, 2025 12:18

fix

d27f7c5

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Mastermind-U reviewed Dec 4, 2025

View reviewed changes

Comment thread tests/conftest.py Outdated

Mastermind-U reviewed Dec 4, 2025

View reviewed changes

Comment thread app/ldap_protocol/ldap_schema/attribute_value_validator.py Outdated

tests: fix task_792

76903e1

Mastermind-U reviewed Dec 4, 2025

View reviewed changes

Comment thread app/ldap_protocol/ldap_schema/attribute_value_validator.py

Naksen self-requested a review December 4, 2025 12:39

milov-dmitriy assigned Naksen Dec 4, 2025

Naksen requested changes Dec 4, 2025

View reviewed changes

fix: some PR comments task_792

0376ba0

milov-dmitriy requested review from Mastermind-U, Naksen and Copilot and removed request for Copilot December 5, 2025 15:12

Merge remote-tracking branch 'origin/main' into add_attr_validations_…

1157525

…task_792

Copilot AI reviewed Dec 5, 2025

View reviewed changes

refactor: copilot fixes task_792

b513f12

Naksen reviewed Dec 8, 2025

View reviewed changes

refactor: pr comments task_792

8af9254

Naksen approved these changes Dec 8, 2025

View reviewed changes

Mastermind-U approved these changes Dec 8, 2025

View reviewed changes

milov-dmitriy changed the base branch from main to dev December 9, 2025 07:31

milov-dmitriy merged commit 41e458f into dev Dec 9, 2025
4 checks passed

milov-dmitriy deleted the add_attr_validations_task_792 branch December 9, 2025 07:33

Naksen pushed a commit that referenced this pull request Mar 6, 2026

Add: directory attributes value validations (#857)

b4bb388

Conversation

milov-dmitriy commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

milov-dmitriy commented Dec 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

milov-dmitriy commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

milov-dmitriy commented Dec 4, 2025 •

edited

Loading

milov-dmitriy commented Dec 5, 2025 •

edited

Loading